Kdyby / Facebook

[DEPRECATED] Use https://github.com/thephpleague/oauth2-facebook instead
Other
42 stars 36 forks source link

Is this repo dead? #57

Closed simPod closed 6 years ago

simPod commented 7 years ago

Asking whether I should wait for PRs to be merged or manage my own fork. Thanks!

fprochazka commented 7 years ago

@simPod are you interested in maintaining this repository?

simPod commented 7 years ago

@fprochazka I prefer to PR but wasn't sure whether they would be ever merged. However, if necessary, I can help maintaining. Better to maintain this than my own

enumag commented 6 years ago

At this point this repo can be considered as dead. I can merge some bugfixes but I probably won't merge features since I never even used this library. If you're still interested in maintaining this I'll gladly give you the access.

simPod commented 6 years ago

Nah, thanks. It would not be wise to rely on unmaintained kdyby libraries so I don't use them anymore. I prefer to dedicate my time to active and perspective OSS projects. Thanks for comment though.

enumag commented 6 years ago

@simPod Understood, this is indeed the better approach. Good luck.

simPod commented 6 years ago

Maybe if you have access, consider marking this repo as abandoned so newcomers are not unpleasantly surprised after integrating this into their project 🤔 Not sure if you have access to packagist as well.

enumag commented 6 years ago

I have access to all Kdyby packages. I'll do as you said.

fprochazka commented 6 years ago

FYI, I suggest using https://github.com/thephpleague/oauth2-facebook

enumag commented 6 years ago

Oh looks like I was wrong. I don't have access to packagist for Kdyby. Can you grant me the access @fprochazka?

fprochazka commented 6 years ago

image

fprochazka commented 6 years ago

@enumag next time please consult me before "abandoning" any more repos :) In this case it's a simple decision, but there is still a lot of projects depending on some packages and there is still a chance people might be willing to take over and start taking care of the lib.

enumag commented 6 years ago

@fprochazka Roger. For now I'd like to mark as abandoned Google, GitHub, GeocoderSeznamMaps and DoctrineDbalBatchImport. I'm definitely not going to mark as abandoned things like Events, Autowired etc, any time soon, you don't need to worry about that.

fprochazka commented 6 years ago

Agreed with Google, GitHub, DoctrineDbalBatchImport ... but is there a reason to abandon GeocoderSeznamMaps? Worked fine list time I checked.

enumag commented 6 years ago

You're right. GeocoderSeznamMaps doesn't seem to use anything that would not work on PHP 7.2 so it's fine.