Remove usage of Nette\Object class

Kdyby / Facebook

[DEPRECATED] Use https://github.com/thephpleague/oauth2-facebook instead

Other

42 stars 36 forks source link

Remove usage of Nette\Object class #62

Closed PavelJurasek closed 6 years ago

enumag commented 6 years ago

Very nice. Could you look into the failing tests?

PavelJurasek commented 6 years ago

I've been digging into it a bit, but I really can't tell what causes that fields first_name and last_name are missing from the response. It shouldn't be related to this PR anyway.

enumag commented 6 years ago

I don't think it's related to this PR. I can certainly merge it as is. But even if I merge it I can't tag a new version for you without the tests passing and I don't have time to fix that.

PavelJurasek commented 6 years ago

Tests are green (coverage not so much..). Is it mergeable?

enumag commented 6 years ago

Merged, thanks. Next time please ping me if I don't respond for a week.