search

Kdyby / FormsReplicator

Other
30 stars 57 forks source link

Fix deprecated in Nette 2.3.10 #41

Closed trejjam closed 8 years ago

trejjam commented 8 years ago

Require Nette/Forms:118

fprochazka commented 8 years ago

Thank you but I don't think this is a good way to solve it. Imho it should be conservated for Nette 2.2 and completely rewritten for Nette 2.3 so it doesn't use extension methods.

trejjam commented 8 years ago

Thank you, do you have some recommendation how to implement $form->addDynamic without extending Form class? (Extending class could be problematic -> Form hasn't have factory)

fprochazka commented 8 years ago

That is my point :) We'll have to conservate it for the people that are still using it with older Nette like 2.2.*, maybe just maybe we might make a 2.3.* compatible version, as I don't think the BC Break of deprecating the extension methods will get into 2.3.* releases.

And then, we can rewrite it with better approach for future applications.

fprochazka commented 8 years ago

Thank you, merged https://github.com/Kdyby/FormsReplicator/commit/662d910af396b4253a2883c08c4440143069aab6