search

Kdyby / FormsReplicator

Other
30 stars 58 forks source link

Stable version for Nette 2.4 #46

Closed attreid closed 5 years ago

attreid commented 8 years ago

will you release stable version for nette/forms 2.4?

fprochazka commented 7 years ago

Sure, once the compatibility is fixed :) Sadly, it will probably require a not-so-small refactoring.

fprochazka commented 7 years ago

Btw, have you seen the big banner in readme? https://github.com/Kdyby/FormsReplicator#save-me-please

solcik commented 5 years ago

I just released the version v2.0.0-rc1 for php 7.1 and nette v3.0.

solcik commented 5 years ago

Please test the release for Nette v2.4 via branch nette-2.4

Tests are green. I am going to release it in about a week as v1.4.0

Yours composer.json

    "require": {
        "nette/forms": "^2.4.9",
        "kdyby/forms-replicator": "dev-nette-2.4"
    },

edit: reflected php versions as per @radekdostal comment.

radekdostal commented 5 years ago

Why PHP < 7.2? Nette 2.4 is compatible up to PHP 7.3.

solcik commented 5 years ago

I'm going to double check. In which nette version was removed Object class?

On Tue, Mar 12, 2019, 08:17 Radek Dostál notifications@github.com wrote:

Why PHP < 7.2? Nette 2.4 is compatible up to PHP 7.3.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kdyby/FormsReplicator/issues/46#issuecomment-471884342, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeOOUtvEQJ3TXma3-w3TWrAu1iKQDDyks5vV1RsgaJpZM4J3tMa .

radekdostal commented 5 years ago

I don't know, but I use FormsReplicator with Nette 2.4 (PHP 7.2, 7.3) up to commit 10133eb2f2bf7aa445ab4a0a7e8701c1f5ffeded.

solcik commented 5 years ago

I reflected real dependencies in 3de1034 and added php 7.2 & 7.3 to Travis (f5627e5ee14e).

Everything seems to be fine.

radekdostal commented 5 years ago

Great. It works.

solcik commented 5 years ago

Released as v1.4.0.

solcik commented 5 years ago

There is also a release v2.0.0 for php ^7.1 & Nette v3.