search

Kdyby / Google

[DEPRECATED] Use https://github.com/thephpleague/oauth2-google instead
Other
24 stars 35 forks source link

Nette 2.3 #26

Open tomas-kulhanek opened 6 years ago

foxycode commented 5 years ago

@fprochazka I'd like to continue on this lib. Will you merge my PR's or will you give me maintainer?

fprochazka commented 5 years ago

I strongly suggest migrating to this: https://github.com/thephpleague?utf8=%E2%9C%93&q=oauth&type=&language=

Maintaining separate libraries for separate providers is unsustainable and doesn't make much sense.

Since a quick google didn't show me any nette integrations for league/oauth2-client, I'd be happy to create a repository for you to create it.

foxycode commented 5 years ago

@fprochazka You mean creating new repository which will use thephpleague/oauth2-google ? How about rewrite this one, which people know? It was my first gues when I needed Google integration. I don't have problem maintaining it. I will need it in few production apps.

BTW: Why not use google/apiclient:^2.0 ?

fprochazka commented 5 years ago

@foxycode the oauth2-client from league is very generic, where you can plug in any of the providers and you should not have to modify your application much. IMHO the correct way is to provide integration with the generic implementation, then it should be easy to just use whatever provider. Which means this repository will still loose meaning.

Google api client covers a lot of google API's, it does not make sense to install client for all of their services, if all you really want is auth.

It didn't occur to me at the beginning, but maintaining separate libs for each providers is hell. Oauth2 is a standartized protocol and there are only slight variances from the providers. Kdyby/Facebook, Google and Github should have never existed.

hrach commented 5 years ago

@fprochazka I suggest archiving these repositories.

fprochazka commented 5 years ago

@hrach that's not a bad idea

fprochazka commented 5 years ago

@foxycode if you want to discuss this further, I'd be happy to do so in #kdyby channel on Pehapkari slack. Also, archiving the repository is easily reversible.