search

Kdyby / Google

[DEPRECATED] Use https://github.com/thephpleague/oauth2-google instead
Other
24 stars 35 forks source link

Google already supports query string in redirect URI parameter. #7

Closed newPOPE closed 10 years ago

newPOPE commented 10 years ago

Or exists some reason why query is reset?

fprochazka commented 10 years ago

Since when? Can you point me at some documentation?

newPOPE commented 10 years ago

I don't know when. Yesterday I implemented Kdyby/Google with ?do=gLogin-reponse successfully. See screen shot 2014-09-13 at 22 17 20 Nothing about query params in redirect uri.

fprochazka commented 10 years ago

You're probably right, I removed it because it worked better without them. And it's good to create route with path only for google auth.

newPOPE commented 10 years ago

What does it mean "better"? :) And why is good create one conrete route for google auth? It is a little inconsistent with Kdyby/Facebook login I think.

So as you wish close this :).

fprochazka commented 10 years ago

I will merge this once I verify it works for me. It's incosistent, because I thought it just works differently. Notice that with facebook, you just whitelist the domain and facebook doesn't care about the rest. With google, you have to have exact url.

newPOPE commented 10 years ago

Okay, I agree.

fprochazka commented 10 years ago

I've verified it works, thank you! :)