search

Kdyby / Redis

Redis storage for Nette Framework
http://packagist.org/packages/kdyby/redis
Other
49 stars 70 forks source link

Support for PHP 7.4 #95

Closed KacerCZ closed 4 years ago

KacerCZ commented 4 years ago

Allow installation on PHP 7.4 Fixed notices Run tools on PHP 7.4

KacerCZ commented 4 years ago

Travis failed only for PHP 7.4 with lowest dependency versions. Nette utils 2.5 emit deprecation message under PHP 7.4.

KacerCZ commented 4 years ago

@VBoss Please review. Nette utils 2.5 does not support PHP 7.4 so deprecation warning is kinda expected.

Spamercz commented 4 years ago

I was looking at this and thinking about limiting utils only to 3.0. Enought time and releases passed, so could you please try removing 2.4 version of utils from composer, if all pases I will merge it and adress it in release properly.

Spamercz commented 4 years ago

well, it would be nice to drop 2.4 dependencies eventualy, but not now. Drop last commit and we can merge it.

KacerCZ commented 4 years ago

I've fixed detection of nette/http 2.4 vs 3.0 in tests. Let's see if all will pass.

KacerCZ commented 4 years ago

OK, tests are now passing.

Spamercz commented 4 years ago

Great, thanks!

JakubBarta commented 4 years ago

Good job! Thank you!

Spamercz commented 4 years ago

@KacerCZ great work on last PRs, meet me anytime at https://www.meetup.com/Pehapkari-Brno and I will give you PHP 6 certified engineer or Proffesional Cache deleter t-shirt :)