search

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework
https://packagist.org/packages/kdyby/translation
Other
89 stars 84 forks source link

Fixes absolute messages in non-prefixed translator #128

Closed JanMikes closed 7 years ago

JanMikes commented 8 years ago

Fixes #126 Possible fix to #114 (not tested) @medhi please would you mind try it out?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.06%) to 71.284% when pulling aaa839cad9feaa8b67411ee5edd05c386cc3d602 on Lexinek:master into f14d9c0755ee8fd9118a741687e8392b0e82780d on Kdyby:master.

zraly commented 8 years ago

I would, but I don't know how to test a pull request, can you help me?

JanMikes commented 8 years ago

@medhi you can use the pull request repository instead of the vendor's default one and run composer update (thats the way i would do it), update your composer.json like this:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Lexinek/Translation"
        }
    ],
    "require": {
        "kdyby/translation": "@dev"
    }
}
zraly commented 8 years ago

Thanks. Tested and seems fixed.

JanMikes commented 7 years ago

@fprochazka Possible to merge, so i can delete repository Lexinek/Translation please?

fprochazka commented 7 years ago

Yeah, this looks reasonable. Thank you guys!