Allow Symfony 3.x - Githubissues

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework

https://packagist.org/packages/kdyby/translation

Other

89 stars 84 forks source link

Allow Symfony 3.x #137

Closed enumag closed 7 years ago

enumag commented 7 years ago

[Closes #118]

coveralls commented 7 years ago

Coverage decreased (-35.6%) to 34.532% when pulling 9612491c9ac9391cc86f76228e155461cdeaac32 on enumag:patch-4 into 14ddd26027f2ec614c759cf675ca57cda4b77fef on Kdyby:master.

coveralls commented 7 years ago

Coverage decreased (-3.8%) to 66.315% when pulling 73a15484f306248048fa8bff7fadb9594846a95a on enumag:patch-4 into 14ddd26027f2ec614c759cf675ca57cda4b77fef on Kdyby:master.

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 70.047% when pulling c2bc948db56709e481727d93ddbc5e19af0e33df on enumag:patch-4 into 14ddd26027f2ec614c759cf675ca57cda4b77fef on Kdyby:master.

enumag commented 7 years ago

@fprochazka The failing test is the same one as in master so it's unrelated to this pull request.

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 70.047% when pulling 2b56ca6b088575855077c43fbd525820dcd00c90 on enumag:patch-4 into 14ddd26027f2ec614c759cf675ca57cda4b77fef on Kdyby:master.

aleswita commented 7 years ago

It's posibble to add dependency on nette/php-generator ~3.0.0 to this pull request?

enumag commented 7 years ago

@aleswita That should be a separate PR in my opinion. Feel free to send one.

fprochazka commented 7 years ago

@enumag Thank you!

fprochazka commented 7 years ago

@aleswita added https://github.com/Kdyby/Translation/commit/0400e8bf266b8b57209f4f65c7dd853abcedae6c :)