search

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework
https://packagist.org/packages/kdyby/translation
Other
89 stars 84 forks source link

Error with latte/latte 2.5.1 #159

Closed BigOHenry closed 5 years ago

BigOHenry commented 5 years ago

Hello, after update latte/latte to 2.5.1 getting this error: Declaration of Kdyby\StrictObjects\Scream::__call($name, $args) should be compatible with Latte\Macros\MacroSet::__call(string $name, array $args)

Could you look at it please? Thank you

dg commented 5 years ago

Solution is to remove use \Kdyby\StrictObjects\Scream; from class TranslateMacros .

petrparolek commented 5 years ago

Doesn't class Scream need? :o

dg commented 5 years ago

No, because its ancestor already uses it.

stanislav-cervenak commented 5 years ago

Actual provisory solution

"repositories": [
    { "type": "vcs", "url": "https://github.com/lulco/Translation.git" }
],
"require": {
    ...
    "kdyby/translation": "dev-fix-translate-macros",
    "symfony/translation": "~4.1.0"
}
petrofcikmatus commented 5 years ago

Hi Guys, when do you plan to release fix for this issue? Thank you!

Isigar commented 5 years ago

Ehm?

jankonas commented 5 years ago

I believe that the fix will be released after some PR that does not break tests appears ;-)

jankonas commented 5 years ago

I just submitted PR which does not break tests, but I have a concern about the minimal Latte version compatibility if this PR is merged. Please see #164 and comment if you have some insight.