search

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework
https://packagist.org/packages/kdyby/translation
Other
89 stars 84 forks source link

Fix Latte 2.5 compatibility #164

Closed jankonas closed 5 years ago

jankonas commented 5 years ago

Resolves #159, closes #160, closes #161, closes #162, closes #163

BC breaks! 😱

Minimal Latte version compatibility?

I removed one line from Kdyby\Translation\Extractors\LatteExtractor that depended on function deprecated in Latte 2.4 and removed in Latte 2.5. But I have no idea whether this breaks compatibility with lower Latte versions (in which case the constraint in composer.json should be updated) or not. Is there someone with better knowledge of this package who knows?

foxycode commented 5 years ago

@jankonas Can you update your PR please?

jankonas commented 5 years ago

@foxycode I will after https://github.com/Kdyby/Monolog/pull/35 is merged and new version is tagged.

jankonas commented 5 years ago

@foxycode FYI since the mentioned PR only allows Nette 3.0 packages I requested tagging new kdyby/monolog version without it (https://github.com/Kdyby/Monolog/issues/38) so I hope it will be soon :-)

jankonas commented 5 years ago

@enumag I think it's ready to merge (and maybe tag new version? 😉).