search

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework
https://packagist.org/packages/kdyby/translation
Other
89 stars 84 forks source link

Nette 3.0 version #165

Closed haltuf closed 5 years ago

haltuf commented 5 years ago

Hello, sending PR to make Kdyby/Translation compatible with Nette v3.0

This PR is conditional of approving kdyby/monolog PR in here: https://github.com/Kdyby/Monolog/pull/35

To make all tests work, I made temporary change (in https://github.com/Kdyby/Translation/commit/d092f0eb1b53ab5dd81e7f22873b8228fed1b941) to composer.json to make the package rely on the branch consisting of the content of this PR. This should be reverted/edited, once kdyby/monolog has a version compatible with Nette 3.0

The code should pass all the tests (at least it does on my travis, coveralls etc.), which unfortunatelly does not guarantee, that it will work, as the code coverage is quite low. Please help me with testing before approving this PR.

Anyone wishing to contribute to this PR, contact me and I can give you access.

haltuf commented 5 years ago

Temporary dependency on my branch of kdyby/monolog removed, replaced with kdyby/monolog:^2.0, that was just released.

martinvenus commented 5 years ago

Kdyby/translation is the only dependency preventing our projects to be upgraded to Nette 3. We are testing our project with haltuf/Translation and it seems ok. Can I help somehow to merge this PR?

haltuf commented 5 years ago

This PR is imho ready to be merged, I also didn't find any problem in real life nette 3.0 use case. The only possible problem is that I'm on out of office now, and won't be able to prepare hotfix (if needed) in the upcoming 2 weeks.