search

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework
https://packagist.org/packages/kdyby/translation
Other
89 stars 84 forks source link

nette 3.1 compatibility #183

Closed vrestihnat closed 3 years ago

vrestihnat commented 3 years ago

Simple adjustments for nette 3.1 and latte 2.10.1 compatibility. Please publish changes.

lulco commented 3 years ago

@enumag please can you take a look to this? It fixes master and other PR will have green build too. Thanks!

lulco commented 3 years ago

any news here?

lulco commented 3 years ago

@vrestihnat you are very close :) please don't give up

vrestihnat commented 3 years ago

I don't give up. I just don't see any more comments so we can close it.

enumag commented 3 years ago

Please check if we also need #182 and/or #179. Don't wanna make a half-baked release.

vrestihnat commented 3 years ago

182 is useful, it solves compatibility with pair macros. #179 is obsolete, #180 is resolved. I will prepare a pull request that contains #182 + test

vrestihnat commented 3 years ago

177 is partially solved and the rest is #182