search

Kdyby / Translation

Integration of Symfony/Translation into Nette Framework
https://packagist.org/packages/kdyby/translation
Other
88 stars 84 forks source link

Phrase with parameters now working with PrefixedTranslator [closes #73] #74

Closed Aurielle closed 9 years ago

Aurielle commented 9 years ago

Attempt to fix #73, however I haven't written any new tests for this. All currently present tests pass.

fprochazka commented 9 years ago

Do you think you can write a test? I would really appreciate it :)

Aurielle commented 9 years ago

I'll look into it.

enumag commented 9 years ago

What about Phrase::setTranslator() typehint?

Aurielle commented 9 years ago

Just a quick note, this is no way abandoned, I haven't had the time yet. I'll prepare the better fix and tests in a week or so. :)

Aurielle commented 9 years ago

Travis is quite taking its time, but I have tried to incorporate the fix the way @fprochazka suggested and written simple tests based on already present testing strings. How does it look?

fprochazka commented 9 years ago

Awesome :+1:

fprochazka commented 9 years ago

@Aurielle thank you, merged!

Aurielle commented 9 years ago

Happy to help :) edit: I forgot about the short array syntax, sorry!