KeRNeLith / QuikGraph

Generic Graph Data Structures and Algorithms for .NET
https://kernelith.github.io/QuikGraph/
Microsoft Public License
471 stars 67 forks source link

Quickgraph.MSAGL nuget package needs to be republished #23

Closed fwaris closed 3 years ago

fwaris commented 3 years ago

References to external DLLs from the published version of the 'MSAGL dll in nuget is different when I build the same from source:

.assembly extern netstandard
{
    .publickeytoken = (
        cc 7b 13 ff cd 2d dd 51
    )
    .ver 2:0:0:0
}
.assembly extern QuikGraph
{
    .publickeytoken = (
        46 bd 58 b0 78 97 59 cb
    )
    .ver 2:2:0:0
}
.assembly extern AutomaticGraphLayout.Drawing
{
    .publickeytoken = (
        e3 3b 67 d3 bb 55 81 e4
    )
    .ver 0:0:0:0
}
.assembly QuikGraph.MSAGL
{

...

.assembly extern netstandard
{
    .publickeytoken = (
        cc 7b 13 ff cd 2d dd 51
    )
    .ver 2:0:0:0
}
.assembly extern QuikGraph
{
    .ver 0:0:0:0
}
.assembly extern AutomaticGraphLayout.Drawing
{
    .ver 0:0:0:0
}
.assembly QuikGraph.MSAGL
{
...

This seems to cause assembly binding issues especially in F# projects.

The issue was fixed after I re-published the package locally using VS 2019 (latest preview) for the build.

KeRNeLith commented 3 years ago

Hello,

Thank you for your report. The published version of QuikGraph.MSAGL had indeed a problem related to its reference to the MSAGL package that was not signed. Latest version the MSAGL package are now signed, so I will plan to publish a new version of QuikGraph.MSAGL referencing a correct version. This new publication will require a new version of the core library too.

KeRNeLith commented 3 years ago

@fwaris I published a new version of QuikGraph packages so the issue should now be fixed (see package >= 2.3.0). Note that I made an update to latest version of the MSAGL libraries.