KeYProject / key

KeY Theorem Prover for Deductive Java Verification
https://key-project.org
Other
42 stars 24 forks source link

Improves KeYSelectionModel usage and removed RuleAppListener from ProofTreeView #3341

Closed unp1 closed 10 months ago

unp1 commented 10 months ago

Factored these changes out from PR #3335 to keep the PRs more focused

Overall:

KeYSelectionModel

ProofTreeView:

Additional synchronizations to fix that quick random clicks on start/stop caused exceptions and/or deadlocks.

codecov[bot] commented 10 months ago

Codecov Report

Merging #3341 (75aff1f) into main (295186f) will increase coverage by 0.00%. The diff coverage is 80.95%.

@@            Coverage Diff            @@
##               main    #3341   +/-   ##
=========================================
  Coverage     37.84%   37.84%           
  Complexity    16895    16895           
=========================================
  Files          2054     2054           
  Lines        125488   125490    +2     
  Branches      21227    21227           
=========================================
+ Hits          47493    47495    +2     
  Misses        72142    72142           
  Partials       5853     5853           
Files Coverage Δ
.../de/uka/ilkd/key/control/AbstractProofControl.java 9.09% <ø> (ø)
...ka/ilkd/key/proof/reference/ReferenceSearcher.java 83.56% <ø> (ø)
...ilkd/key/control/AbstractUserInterfaceControl.java 79.01% <89.47%> (+0.53%) :arrow_up:
...a/de/uka/ilkd/key/macros/SequentialProofMacro.java 6.25% <0.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Drodt commented 10 months ago

I tested it on my machine and could not produce any deadlocks.

unp1 commented 10 months ago

This PR is from my point of view now stable and complete