Closed tobias-rnh closed 9 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
2d9f36c
) 37.94% compared to head (778fd6a
) 37.97%.
Files | Patch % | Lines |
---|---|---|
...y/rule/conditions/ApplyUpdateOnRigidCondition.java | 98.27% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix #3254 To prevent name clashes with bound variables, the free variables in the update and the bound variables of a formula are compared. In case of a clash, the bound variable is renamed and a substitution is performed on the subterms of the formula automatically before applying the update.
The new clash free name is created by appending a counter to the original name of the bound variable. However: as only the variables contained in the update and the formula the update is applied on are considered, the following situation is still possible:
Currently, there is no way to get names on higher levels than the update. So if the different meanings of
a1
in this situation are still of concern, it might be needed to find a solution on a higher level than ApplyUpdateOnRigidCondition, e.g. when parsing.Tests for ApplyUpdateOnRigidCondition were also added.