Open FliegendeWurst opened 8 months ago
Attention: Patch coverage is 3.44828%
with 28 lines
in your changes are missing coverage. Please review.
Project coverage is 37.84%. Comparing base (
99658cc
) to head (d19e2d7
). Report is 3 commits behind head on main.:exclamation: Current head d19e2d7 differs from pull request most recent head a0746d8
Please upload reports for the commit a0746d8 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR fixes one of the original bug (file belongs to a student exercise, thus I do not want to attach it for the moment). However, there is a follow-up bug with the same file. Could you also look into the second bug, please?
I think the other bug you are referring to is fixed by #3438
I think the other bug you are referring to is fixed by #3438
Yes, thanks. I did not notice the other fix.
I really don't understand the test failure. None of the changes in this PR change anything relevant to normal proof search. I'll do a no-op commit and push again.
I really don't understand the test failure. None of the changes in this PR change anything relevant to normal proof search. I'll do a no-op commit and push again.
I was having trouble with tests failing for no reason at all in the last few weeks too. First it was the unit tests only on Ubuntu and then the integration test testRunAllFunProofs
. The caches in the repository were completely filled and after making some space, we got the tests to pass. I don't know if this could also be the problem here, but it might be worth a try.
Intended Change
This PR fixes a slicing failure with a specific proof. In that particular case, the dynamically added taclet was slightly too different for the previous code to pick it up.
Type of pull request
Ensuring quality
Additional information and contact(s)
cc @WolframPfeifer who reported the bug
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.