Open wadoon opened 6 months ago
Attention: Patch coverage is 44.55959%
with 107 lines
in your changes missing coverage. Please review.
Project coverage is 38.16%. Comparing base (
0ebb8b5
) to head (2eae40e
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Refactoring
This PR starts the removal of generic data classes in favor of Java records (aka. named tuples). In this PR, only
Triple
andQuadruple
are removed.In general, generic parametric data classes (
Tuple
,Union
, ...) lead to unreadable, incomprehensible code, e.g., what does the entityTriple<StatementBlock, URI, Integer>
express? Answer: It is the key in a map to find block contracts. Using the recordBlockContractKey
expresses this better than triple of something.Therefore, records give you the chance of defining useful variable names, and documentation, and also avoid auto-boxing (hence NPE).
Intended Change
No use of
Triple<…>
andQuadruple<…>
.Type of pull request
Ensuring quality