KeYProject / key

KeY Theorem Prover for Deductive Java Verification
https://key-project.org
Other
41 stars 24 forks source link

Generate easier POs for non-trivial diverges clauses #3430

Open Drodt opened 5 months ago

Drodt commented 5 months ago

Related Issue

This pull request fixes #29.

Intended Change

A non-trivial (i.e, neither true nor false) diverges clause results in two contracts to be verified. Previously, there was one where the value of the clause (here div) is not true and the method therefore terminates, and one where the method does not terminate.

E.g., the two POs would look like pre & !div -> <m()>post and pre -> [m()] post. This resulted in more complex proofs, because the case where div is false had to be considered as well for the second PO.

This PR changes the POs to

  1. pre & !div -> <m()>post and
  2. pre & div -> [m()] post

Hence, we have a proper cut.

Type of pull request

Ensuring quality

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.77%. Comparing base (1fb0c10) to head (7472e4a). Report is 114 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3430 +/- ## ========================================= Coverage 37.77% 37.77% + Complexity 17031 17030 -1 ========================================= Files 2076 2076 Lines 126950 126953 +3 Branches 21381 21381 ========================================= + Hits 47952 47954 +2 Misses 73092 73092 - Partials 5906 5907 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.