Hackeython/error reporting

mattulbrich commented 5 months ago

This brings the edits from the error reporting group at the hackeython onto the main branch

Intended Change

Have better parser message.

The code driving the parsers has been adapted. Also the code that produces the JML code to parse had to be adapted to contain the correct spaces. Moreover, message extraction from ANTLR exception classes has been improved.

Type of pull request

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactoring (behaviour should not change or only minimally change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] There are changes to the (Java) code
[ ] There are changes to the taclet rule base
[ ] There are changes to the deployment/CI infrastructure (gradle, github, ...)
[ ] Other:

Ensuring quality

[x] I made sure that introduced/changed code is well documented (javadoc and inline comments).
[ ] I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
[x] I added new test case(s) for new functionality.
[ ] I have tested the feature as follows: ...
[ ] I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

Collaboration with @FliegendeWurst @MarcoScaletta @LennartKleinwort

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 73.91304% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 37.88%. Comparing base (9cc569c) to head (1088e18).

:exclamation: Current head 1088e18 differs from pull request most recent head 30afba3. Consider uploading reports for the commit 30afba3 to get more accurate results

Files	Patch %	Lines
...main/java/de/uka/ilkd/key/util/ExceptionTools.java	67.34%	11 Missing and 5 partials :warning:
...e/uka/ilkd/key/java/recoderext/JMLTransformer.java	85.71%	0 Missing and 2 partials :warning:
...in/java/de/uka/ilkd/key/nparser/ParsingFacade.java	50.00%	2 Missing :warning:
...de/uka/ilkd/key/speclang/jml/JMLSpecExtractor.java	88.23%	0 Missing and 2 partials :warning:
...a/ilkd/key/nparser/builder/DeclarationBuilder.java	50.00%	1 Missing :warning:
...e/uka/ilkd/key/nparser/builder/DefaultBuilder.java	50.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3432 +/- ## ============================================ + Coverage 37.87% 37.88% +0.01% - Complexity 17083 17089 +6 ============================================ Files 2092 2092 Lines 127520 127596 +76 Branches 21466 21478 +12 ============================================ + Hits 48298 48343 +45 - Misses 73316 73332 +16 - Partials 5906 5921 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FliegendeWurst commented 5 months ago

This PR will also fix #3441

mattulbrich commented 4 months ago

Ping for a review, @WolframPfeifer. Thx.

KeYProject / key