KeYProject / key

KeY Theorem Prover for Deductive Java Verification
https://key-project.org
Other
41 stars 24 forks source link

Fixed the path-to-smt-solver bug in windows #3434

Closed vb213 closed 3 months ago

vb213 commented 5 months ago

Intended Change

The specified path to a smt solver has been assembled incorrectly from the user input but still got cached in the proofIndependentSettings.props file. This caused a crash when restarting KeY. Now,

  1. the path is assembled correctly and
  2. an invalid smt solver path in proofIndependentSettings.props will be ignored, thereby avoiding a crash on program start.

Type of pull request

Ensuring quality

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 37.91%. Comparing base (7254776) to head (f423328). Report is 21 commits behind head on main.

:exclamation: Current head f423328 differs from pull request most recent head b5f8c17. Consider uploading reports for the commit b5f8c17 to get more accurate results

Files Patch % Lines
.../key/smt/solvertypes/SolverTypeImplementation.java 59.09% 4 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3434 +/- ## ============================================ + Coverage 37.86% 37.91% +0.05% + Complexity 17079 17071 -8 ============================================ Files 2092 2076 -16 Lines 127596 127026 -570 Branches 21478 21385 -93 ============================================ - Hits 48316 48168 -148 + Misses 73355 72952 -403 + Partials 5925 5906 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.