KeYProject / key

KeY Theorem Prover for Deductive Java Verification
https://key-project.org
Other
41 stars 24 forks source link

Generalize ParsableVariable and Schemavariables #3436

Closed Drodt closed 2 months ago

Drodt commented 5 months ago

Related Issue

Intended Change

This PR moves the ParsableVariable interface to ncore, makes it no longer an Operator and renames AbstractSV to OperatorSV as this interface now handles all schema variables that may be operators.

It also handles the refactorings necessary to adapt to this change. I.e., changing types where necessary, changing how modality schema vars are matched, and some changes to the term builder.

Also fixes the Github workflow.

Type of pull request

Ensuring quality

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 48.11166% with 316 lines in your changes are missing coverage. Please review.

Project coverage is 37.96%. Comparing base (7254776) to head (07ad420). Report is 116 commits behind head on main.

:exclamation: Current head 07ad420 differs from pull request most recent head a16defe

Please upload reports for the commit a16defe to get more accurate results.

Files Patch % Lines
...de/uka/ilkd/key/speclang/WellDefinednessCheck.java 0.00% 43 Missing :warning:
...a/ilkd/key/rule/tacletbuilder/TacletGenerator.java 36.00% 32 Missing :warning:
...ava/de/uka/ilkd/key/smt/newsmt2/SeqDefHandler.java 0.00% 17 Missing :warning:
.../src/main/java/de/uka/ilkd/key/rule/TacletApp.java 65.90% 8 Missing and 7 partials :warning:
...e/uka/ilkd/key/speclang/MethodWellDefinedness.java 0.00% 15 Missing :warning:
...e/uka/ilkd/key/rule/AuxiliaryContractBuilders.java 12.50% 9 Missing and 5 partials :warning:
.../uka/ilkd/key/speclang/DependencyContractImpl.java 13.33% 13 Missing :warning:
.../main/java/de/uka/ilkd/key/java/TypeConverter.java 14.28% 7 Missing and 5 partials :warning:
...c/main/java/de/uka/ilkd/key/logic/TermBuilder.java 33.33% 9 Missing and 1 partial :warning:
.../key/speclang/FunctionalOperationContractImpl.java 65.51% 10 Missing :warning:
... and 56 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3436 +/- ## ============================================ + Coverage 37.86% 37.96% +0.10% + Complexity 17079 17058 -21 ============================================ Files 2092 2081 -11 Lines 127596 126912 -684 Branches 21478 21332 -146 ============================================ - Hits 48316 48186 -130 + Misses 73355 72819 -536 + Partials 5925 5907 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.