search

KeYProject / key

KeY Theorem Prover for Deductive Java Verification
https://key-project.org
Other
41 stars 24 forks source link

PrettyPrinting: Show the availability by showing a comment. #3443

Closed wadoon closed 3 months ago

wadoon commented 5 months ago

Intended Change

In #3400, we extend the pretty printing of Java AST by a service object. This enables new pretty printing thingies like showing availability of specification for certain objects: loops and blocks.

It uses a comment /*C*/: image

mattulbrich commented 5 months ago

I am sorry. I do not understand the purpose of this PR.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 37.87%. Comparing base (cde763f) to head (5b2dfe3).

Files Patch % Lines
...rc/main/java/de/uka/ilkd/key/pp/PrettyPrinter.java 13.33% 9 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3443 +/- ## ============================================ - Coverage 37.88% 37.87% -0.01% - Complexity 17082 17083 +1 ============================================ Files 2090 2090 Lines 127485 127499 +14 Branches 21466 21471 +5 ============================================ + Hits 48294 48295 +1 - Misses 73285 73294 +9 - Partials 5906 5910 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Drodt commented 3 months ago

If I understand this PR correctly, I am against merging this PR. Comments in the term view would clutter the view unnecessarily and do not add much, in my opinion.