KeYProject / key

KeY Theorem Prover for Deductive Java Verification
https://key-project.org
Other
42 stars 24 forks source link

Update pull_request_template.md #3446

Closed mattulbrich closed 3 months ago

mattulbrich commented 3 months ago

Intended Change

Updated and improved the pull request template.

Removing the checkboxes which always (if unticked) indicated that the PR is only partially finished in the overview. Replaced by item list from which items can be deleted.

Refining the structure. Adding a new subsection "Plan".

Type of pull request

Ensuring quality

n/a

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.85%. Comparing base (fb58c33) to head (bac61ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3446 +/- ## ============================================ - Coverage 37.85% 37.85% -0.01% Complexity 17042 17042 ============================================ Files 2082 2082 Lines 127290 127290 Branches 21441 21441 ============================================ - Hits 48184 48183 -1 Misses 73194 73194 - Partials 5912 5913 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wadoon commented 3 months ago

Can we get rid of the not semantically-correctly used todo items?

I find it very annoying if you look on a PR and Github says "5 out of 10 tasks done".

WolframPfeifer commented 3 months ago

Can we get rid of the not semantically-correctly used todo items?

* [ ]  Yes

* [ ]  No

* [ ]  Maybe?

I find it very annoying if you look on a PR and Github says "5 out of 10 tasks done".

Is this not exactly what the PR does?

mattulbrich commented 3 months ago

I find it very annoying if you look on a PR and Github says "5 out of 10 tasks done".

That's the reason for the PR. If we have checkboxes than we should have them for things were 10/10 is the desired goal, and fewer should not be merged.