search

Keats / jsonwebtoken

JWT lib in rust
MIT License
1.69k stars 271 forks source link

Add x5c Header #181

Closed olitha closed 2 years ago

olitha commented 3 years ago

The x5c Header contains a certificate chain as base64 encoded DER certificates and can be used outside the jsonwebtoken lib to get the public key for signature verification. Additionally the certificate chain can be verified by the application.

Can we add the x5c header? Only to make it available to applications?

jnicholls commented 3 years ago

Wow, I literally implemented this last night with the intention to open an issue and submit a PR this morning. However, I did it differently and I think more correctly. I'm not sure how your PR didn't cause lots of tests to break either 🤔 I will submit my PR shortly after I rebase with your update.

jnicholls commented 3 years ago

@Keats Do you like to close out these issues once a release is done, or after code is in next? I'll quickly take the opportunity to say thanks for your contributions to the community as well!

Keats commented 3 years ago

Forgot to reply! Thanks for the kinds words, I'll close all relevant issues on release - probably this weekend if nothing else pops up.