search

Keats / jsonwebtoken

JWT lib in rust
MIT License
1.67k stars 266 forks source link

CERTIFICATE tag for pem files #274

Closed Alexey-N-Chernyshov closed 1 year ago

Alexey-N-Chernyshov commented 1 year ago

Fix for issues #259, surrealdb/surrealdb#1256.

Adds CERTIFICATE tag for pem files. RSA tests were extended with certificates. Self-signed certificates were generated as follows:

# openssl req -new -key private.pem -out certificate.csr
# openssl x509 -req -days 358000 -in certificate.csr -signkey private.pem -out certificate.crt

certificate.crt files may be checked at https://www.sslchecker.com/certdecoder

Also there are some fixes found by clippy in the first two commits.

Keats commented 1 year ago

Can you add a note somewhere in the test folder next to the certificate for the commands? I know it's in git blame but it's just that I'd like to put the other commands eventually as I never remember them

Alexey-N-Chernyshov commented 1 year ago

Also I added a note with commands in tests/rsa/README.md.

Can you make a release, please?