search

Keats / jsonwebtoken

JWT lib in rust
MIT License
1.62k stars 252 forks source link

[RFC] Migrate to ring-0.17 #309

Closed xiangzhai closed 7 months ago

xiangzhai commented 1 year ago

Hi @Keats

ring-0.17 added a Rust ChaCha20 implementation and provided an implementation of bn_mul_mont that works on all targets that don't have an assembly language implementation.

The fallback (implemented in Rust) might fixed #246 for darwin aarch64. And it also works for LoongArch64 target which don't have optimized assembly language implementation.

I want to help migrating to ring-0.17 when ring-0.17.0 upstream was ready.

Could you give me some suggestion please?

Thanks, Leslie Zhai

Keats commented 1 year ago

We're not in a hurry to upgrade, let's wait till it's released for a while before upgrading it as well.

xiangzhai commented 1 year ago

Hi @Keats

I see :)

Thanks, Leslie Zhai

spruce commented 11 months ago

Some time ago I tried to work with jsonwebtokens on my MacBook Pro M1. It wouldn't compile. The fix was to require ring version of at least 0.16.19.

Would it be possible to upgrade the dependency to at least that?

Keats commented 11 months ago

We are not hardcoding any specific version for ring so a cargo update should work, unless another dependency is requiring something specific.

xiangzhai commented 11 months ago

Hi @spruce

The fallback (implemented in Rust) might fixed https://github.com/Keats/jsonwebtoken/issues/246 for darwin aarch64.

You could try https://github.com/xiangzhai/ring/tree/0.16.20-loongarch64-fallback

Thanks, Leslie Zhai

ravenclaw900 commented 9 months ago

Now that ring 0.17.0 is released, are there plans to move forward on this?

Keats commented 9 months ago

No need to rush, it's been released 3 days ago. We can hold off a bit until it's been tested a bit more

Keats commented 7 months ago

It's in 9.2.0