search

Keats / jsonwebtoken

JWT lib in rust
MIT License
1.62k stars 252 forks source link

The pinned tests fails #314

Closed giraffate closed 1 year ago

giraffate commented 1 year ago

https://github.com/Keats/jsonwebtoken/actions/runs/5027342878/jobs/9016716260#step:5:77

error: package regex v1.8.1 cannot be built because it requires rustc 1.60.0 or newer, while the currently active rustc version is 1.59.0

The pinned version is 1.59.0. The regex is a part of the dev-dependencies. So, would the pinned version be updated to 1.60.0? (In this project, I don't know that whether the pinned version is different from msrv.)

Keats commented 1 year ago

Hmm that's an interesting situation. I guess we can pin criterion for now since it's dev only? (I'm guessing regex is in criterion)

giraffate commented 1 year ago

Yes, regex is dependencies of criterion. I don't know this is the good way, but it works when we pin regex directly in dev-dependencies. https://github.com/Keats/jsonwebtoken/pull/315

Keats commented 1 year ago

Fixing it by bumping the pinned version. Thanks!