Closed Richard-Rogalski closed 11 months ago
Welp, unsure if this helps, but it builds if e.description_())
is replaced by ErrorKind::RsaFailedSigning
.
Note that this isn't a proper fix
We'll have to wait for a proper fix. I wonder what changed prior the introduction of e.description_())
.
Looks like e.description_()
was added in 30571cafd2949f3d769a1658695ef5c9e9c4f8e4. Reverting it should probably make it work. Unsure of the impact if this commit was reverted.
fyi: Richard and I both have ppc64le (power8) systems
It seems present in the fork? https://github.com/IBM/ring/blob/master/src/error.rs#L153 but not in the ppc branch: https://github.com/IBM/ring/blob/ppc-0.16.20/src/error.rs#L134
Hmm, thanks for pointing that out. I didn't look to see if it was present in the ppc branch. I locally added it in the ppc branch and it now builds fine. (We are building conduit)
(I did a quick "fix", so it's not a proper fix, but it works. I'll have to check that out then)
I only added this part
/// The value returned from <Self as std::error::Error>::description()
pub fn description_(&self) -> &'static str {
self.0
}
builds fine, but it's missing most of https://github.com/Keats/jsonwebtoken/commit/30571cafd2949f3d769a1658695ef5c9e9c4f8e4.
Thanks for pointing that out!
LIBCLANG_PATH="/usr/lib/llvm/15/lib64/" cargo build --release
[...]
Compiling jsonwebtoken v8.3.0
[...]
Finished release [optimized] target(s) in 6m 29s
@Richard-Rogalski you can temporarily do this
ugh, I'll make a PR to IBM/ring I guess.. thanks y'all <3
Hi, I just pushed a revised version of ppc-0.16.20
to IBM/ring
that is actually based on 0.16
. The original version included some commits intended for a future version that should not have been there, hopefully this should address the issue. As it was a git history rewrite, you may need to force a clean rebuild to make sure it fetches the new version. Please let me know if you encounter any issues.
Thank you so much! Just in time for my birthday!
CPU: ppc64le (power8) Rust:
rustc 1.71.0-nightly (8ede3aae2 2023-07-12) (gentoo)
and alsorustc 1.71.0 (8ede3aae2 2023-07-12) (gentoo)
Version:jsonwebtoken = "8.3.0"
I think this problem is because of either ppc64le, or (more likely) ring. Upstream ring does not have support on PPC, but IBM has a fork that does, https://github.com/IBM/ring/ . The error is:
Full build log will be attached below.
I don't know much about rust or where the issue really lies.... but I would be willing to (try) making a PR to make ring optional in favor of the system openssl (openssl-sys), if that would be alright :) ( if that is alright, can I also get an estimate on how hard that would be :b )
build.log