Keats / jsonwebtoken

JWT lib in rust
MIT License
1.61k stars 253 forks source link

Feature request : optionnaly use aws-lc-rs instead of ring #389

Closed nicolaspernoud closed 1 month ago

nicolaspernoud commented 1 month ago

Hello,

Thanks for this useful crate. A lot of the ecosystem seems to be moving from ring to aws-lc-rs as default cryptographic library (like https://github.com/rustls/rustls/blob/a2c21fe0509f634431e72bffe8803fca1f892d56/rustls/Cargo.toml#L31) . Maybe it would be nice to propose the alternative.

Best regards.

Keats commented 1 month ago

See https://github.com/Keats/jsonwebtoken/pull/377

It seems there are issues building it on Windows?

nicolaspernoud commented 1 month ago

Well, maybe the best would be to offer the choice between ring and aws-lc-rs, defaulting to ring on windows ?

Keats commented 1 month ago

I'd rather not have multiple backend if possible

nicolaspernoud commented 1 month ago

Understandable, but that seems to be the tendency in all the librairies switching from ring to aws-lc-rs... I guess that the alternative is to wait for aws-lc-rs to build properly on windows. Closing for now...