eval_in_condition: Use safe_eval rather than eval (#738)

Keats / tera

A template engine for Rust based on Jinja2/Django

http://keats.github.io/tera/

MIT License

3.44k stars 280 forks source link

Closed Smerity closed 2 years ago

Smerity commented 2 years ago

Fixes #738

Added two simple tests to ensure there isn't a regression
The fix is simple though would appreciate a sanity check, specifically that calling safe_eval_expression in eval_in_condition can't result in safety issues
- I don't believe it does but a double check from someone more familiarly with the codebase would be appreciated =]

Keats commented 2 years ago

Thanks!