Closed robjtede closed 1 year ago
I think I'm not going to do another release until v2
Apologies for the noise @Keats, but I'd encourage you to create such breaking releases soon rather than later, as I wish I'd done with Actix Web v4.
I will do a small release for that since i don't know when i will be done with tera v2. Can you fix the CI?
this pinning scheme is somewhat fruitless anyway
As I stumbled here from something tangentially related, I'll add my two cents. I do not think that pinning your dependencies in the crate is the correct way to maintain a MSRV. In SNAFU, I support all the way back to Rust 1.34. I use two main techniques:
Most people use newer versions of Rust and are in the happy default path. The minority that need older versions can still use the crate with a little extra work.
The concensus among most crates (evidently) and authors is that an MSRV bump is not classed as a breaking change.
This may be, but I think what's more important is for each crate to document their decision on the matter. I am one of the (apparent) minority that does think that a MSRV bump mandates a semver-incompatible release.
Motivation
Maintaining such an old MSRV is fighting a losing battle; trust me, I've tried.
(Somewhat hillariously,) Cargo's resolver will prefer to downgrade
tera
versions to allow higher compatiblechrono-tz
&thread_local
versions. So, this pinning scheme is somewhat fruitless anyway; blocking many users from being able to access newer Tera features and fixes. (This might, in part, explain why download numbers on crates.io still seem to favor ofv1.17.1
.)Notes
The concensus among most crates (evidently) and authors is that an MSRV bump is not classed as a breaking change.
I've used 1.63 as the minimal update necessary for builds to succeed without pinning transitive deps. Though, for future-proofing, I'd actually suggest something quite a bit higher like
1.65
, released Nov 2022, so a good support timespan still.closes #833