search

Keats / tera

A template engine for Rust based on Jinja2/Django
http://keats.github.io/tera/
MIT License
3.48k stars 281 forks source link

Bump globwalk dep to 0.9 #886

Closed Gilnaa closed 9 months ago

Gilnaa commented 9 months ago

Bumps globwalk to version 0.9, mostly to get rid of bitflags 1.* transitive dependecy. (see https://github.com/Gilnaa/globwalk/pull/34)

Gilnaa commented 9 months ago

It looks like ignore 0.4.21 has a much higher MSRV due to the new use of OnceLock. (available since Rust 1.70.0) This doesn't look a regression that is related to this PR, (this can be reproduced by checking-out an older version of globwalk and running cargo +1.65.0 check).

Not sure what to make of it, honestly.

It's possible to explicitly mention ignore = "<=0.4.20" in tera's Cargo.toml, and it would technically make this test pass, but will limit tera's users to an old version of ignore until the constraint is removed; possibly causing conflicts with other crates. Is there a best-practice I'm missing?

Keats commented 9 months ago

It's the problem of having a MSRV, in practice it can change at any point without a direct dependency update :/ In practice I think I will just wait for v2 to upgrade