search

Kebechet / Maui.RevenueCat.InAppBilling

MIT License
13 stars 6 forks source link

Adding github actions pipeline for automatic delivery to nuget.org #47

Open Bloodyairtimer opened 1 week ago

Bloodyairtimer commented 1 week ago

Added a pipeline for automatic build + package creation and versioning for pushing to nuget.org.

Only thing to configure is the API-key for pushing to nuget.org and remove the if: false from the nuget push step.

Kebechet commented 1 week ago

Thanks man for the contribution! I was too lazy to implement this 😅 In following days I will take a look.

Resolves: https://github.com/Kebechet/Maui.RevenueCat.InAppBilling/issues/36

Bloodyairtimer commented 1 week ago

Thanks man for the contribution! I was too lazy to implement this 😅 In following days I will take a look.

Resolves: #36

Just a small contribution for the work you did for migrating it to MAUI. And it would come handy as i'm working on an upgrade of the revenuecat SDK and the upgrade to .net 9. Not sure if my knowledge of binding projects would be enough to do that.

Kebechet commented 1 week ago

Thanks man for the contribution! I was too lazy to implement this 😅 In following days I will take a look. Resolves: #36

Just a small contribution for the work you did for migrating it to MAUI. And it would come handy as i'm working on an upgrade of the revenuecat SDK and the upgrade to .net 9. Not sure if my knowledge of binding projects would be enough to do that.

I tried to put all necessary information how to create those bindings into READMEs: Android iOS it should answer you most questions on how to create updated bindings.

Our project will migrate to .NET 9 in january/february so until than I wont bump the package version. But even if it is on .NET8 it should be backward compatible. Regarding upgrade to newer RevenueCat versions, we didnt need any new features and the current one seems to be stable. Why do you need a newer one ? (I am not against the update I just didnt have a reason to do it)

Bloodyairtimer commented 1 week ago

Currently having some issues upgrading the Android part as there are some AndroidX references that need a different version.

Upgrading the RevenueCat SDK was mainly for trying to see if I could use the paywalls. If I looked correctly at the current version used that's not in there yet.

Kebechet commented 1 week ago

Regarding Android compatibility I had to work with Android lib versions that were compatible with AndroidX bindings already created for MAUI. Sometimes updating to the latest RevenueCat version is not possible because versions they use are not yet created for MAUI.

I havent worked with paywalls yet, so Idk how do they work. But certainly it would be a good feature to add

If you resolve some other problems regarding binding creation that are not mentioned in the Readme please update it as well so that next time we have less struggles.