search

KebsCS / KBotExt

All-in-one application that sends custom requests to League of Legends LCU api
465 stars 76 forks source link

issue with instalocking fiddlesticks #153

Closed daeskk closed 1 year ago

daeskk commented 1 year ago

the instalock isn't working for fiddlesticks, I think there's an issue with the name of the champion it displays as 'FiddleSticks', and when I switch to another section (i.e Profile) this bug occurs.

image

BennyExtreme commented 1 year ago

Hi! I can confirm.

After a bit of debugging: Here we are comparing the names returned by the lcu (directly from the alias key) with the names extracted from the communitydragon skins file (from the loadScreenPath key).

In this specific case the two values are not the same, from lcu is "alias" : "FiddleSticks" so "FiddleSticks", while from communitydragon is "loadScreenPath": "/lol-game-data/assets/ASSETS/Characters/Fiddlesticks/Skins/Base/FiddleSticksLoadscreen.jpg" so "Fiddlesticks" with a lowercase 'S'.

I think we could solve this by implementing the same strategy used in the communitydragon skins file to extract the champion name for lcu as well.

@KebsCS Please tell me what do you think, If you like the idea I will do a pr shortly.

Btw, sorry for the delay and hugs to everyone 😛🤗