Keck-DataReductionPipelines / KAI

Keck AO Imaging DRP
https://keck-datareductionpipelines.github.io/KAI/
6 stars 10 forks source link

Can KAI avoid using legacy IRAF software stack? #19

Open cdfassnacht opened 2 years ago

cdfassnacht commented 2 years ago

I would guess (and I may be completely wrong here) that the only thing that KAI really needs from astroconda is the drizzling code. I think that works fine with the astroconda standard installation and, thus, does not require installing the legacy software stack (with iraf). Since accessing the iraf code, especially with newer versions of MacOS, is hard (64 bit vs. 32 bit issues), I was wondering if eventually KAI could disconnect from iraf. In looking quickly through some of the code, it seems as though a lot of the calls to iraf are for things like imcombine, imarith, etc., that should be easy to write in (non-iraf) python. Of course this would require a fair amount of work, but if the transition were possible then the code would be a lot more user friendly for those of us with Macs.

followthesheep commented 2 years ago

The drizzle package is from IRAF itself and the version we use is the 32 bit version because STScI never made a 64 bit version of it. Astrodrizzle, which is a more standalone code, does not work with our images because it is tuned to HST. There are some other possible drizzle codes, but preliminary tests suggest they do not work as well as the IRAF drizzle code.

The other major package is the IRAF geometry package that is used for distortion correction.

The transition is possible and would be a good goal for the future, but we don't have anyone with the time to do it now. Let us know if there is anyone you have in mind that can take this on.

Another route that I've had success with on new macs is to use docker containers to make the installation more platform agnostic.

On Thu, Jul 21, 2022 at 4:57 PM Chris Fassnacht @.***> wrote:

I would guess (and I may be completely wrong here) that the only thing that KAI really needs from astroconda is the drizzling code. I think that works fine with the astroconda standard installation and, thus, does not require installing the legacy software stack (with iraf). Since accessing the iraf code, especially with newer versions of MacOS, is hard (64 bit vs. 32 bit issues), I was wondering if eventually KAI could disconnect from iraf. In looking quickly through some of the code, it seems as though a lot of the calls to iraf are for things like imcombine, imarith, etc., that should be easy to write in (non-iraf) python. Of course this would require a fair amount of work, but if the transition were possible then the code would be a lot more user friendly for those of us with Macs.

— Reply to this email directly, view it on GitHub https://github.com/Keck-DataReductionPipelines/KAI/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY56P5QR4DNDJOQKD7LF23VVHPX5ANCNFSM54JMG2MQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cdfassnacht commented 2 years ago

Thanks Tuan! I hadn't realized that you weren't using astrodrizzle. I'll try using docker or, as I saw somewhere online, a VPN that may allow me to run 32-bit iraf code.

jluastro commented 9 months ago

@jluastro and @skterry are now working to get rid of this dependence. Sean is working on the drizzle replacement and Jessica is working on everything else (noiraf branch). Not ready for any kind of use; but just wanted to make a push to get this done sooner rather than later.

cdfassnacht commented 9 months ago

Yay! Thanks for looking into this.

AstroPatty commented 1 month ago

Hi all

Is there any update on the status of these changes?

jluastro commented 1 month ago

Actively working on it. Remains substitutions are cosmic ray rejection, and image registration via cross correlation. Then we need to test for astrometric and photometric reliability. Planned to complete this summer. On Jun 21, 2024, at 10:42 AM, Patrick Wells @.***> wrote: Hi all Is there any update on the status of these changes?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>