Keck-DataReductionPipelines / KCWI_DRP

KCWI python DRP
BSD 3-Clause "New" or "Revised" License
8 stars 12 forks source link

Rti fix dark processing #120

Closed lfuhrman closed 2 years ago

lfuhrman commented 2 years ago

Found error in reducing Arcs when there was more than one configuration with >1 _trace file created.

Changes:

ExtractArcs.py -- read the trace instead of using the last one read. Some nights contain multiple traces, and it relies on an order of reduction if using the last trace created. Changed from reading the one in 'context' to explicitly read the matching trace.

FindBars.py -- Changed name of trace file to be the name of the contbar calibration file +_trace.

TraceBars.py -- added stateid to the header as a secondary method to match the trace.

MakeMasterDark.py -- changed location to redux dir for making the master flat, originally looking in lev0 for _int files. Also updated proctable to have the correct name of the master flat created.


Encountered errors in the masking routines:

bspline/Bspline.py

ran into index errors in mask points. Added an exception in the case where the index used is actually an array.

Found an issue with the array dimensions in the except LinAlgError route. The dimensions did not match the equality set further on for ll[:, 0:n] = lower.