Missing pixel in cube assembly?

Keck-DataReductionPipelines / KCWI_DRP

KCWI python DRP

BSD 3-Clause "New" or "Revised" License

10 stars 14 forks source link

Missing pixel in cube assembly? #133

Open yuguangchen1 opened 2 years ago

yuguangchen1 commented 2 years ago

Hi!

I noticed that after MakeCube.py, the size of the cube is actually 1 pixel smaller than the production from IDL pipeline in the Y-direction. Could this be an array slicing bug, since the endpoint definition is different?

Thanks!

MNBrod commented 2 years ago

There is indeed an off-by-one error that seems to have originated with the IDL port. I have a fix to make this DRP's outputs consistent with the IDL one, and will push it shortly.