Saturation check not performed?

Keck-DataReductionPipelines / KCWI_DRP

KCWI python DRP

BSD 3-Clause "New" or "Revised" License

8 stars 12 forks source link

Saturation check not performed? #135

Open yuguangchen1 opened 2 years ago

yuguangchen1 commented 2 years ago

Hi!

I just noticed that the current version of the pipeline seems to miss the saturation check.

The IDL pipeline performs the check at stage 1, right after the images are loaded and before the bias subtraction. However, this step is missing in the current pipeline between "ProcessObject" and "SubtractBias" primitives. Therefore, the flag extension if the "_int.fits" files does not contain flags==1 pixels, which was correctly identified in the IDL pipeline.

yuguangchen1 commented 2 years ago

FYI. We provide a hotfix of this issue in our forked version: https://github.com/prusinski/KCWI_DRP/commit/5b2f6e0e1a91e411d30d8e4b9c1673c4cd88379d