Keck-DataReductionPipelines / KCWI_DRP

KCWI python DRP
BSD 3-Clause "New" or "Revised" License
9 stars 14 forks source link

Unable to create MasterSky with 1.1.0 update #159

Closed rremigio closed 11 months ago

rremigio commented 11 months ago

I am trying to reduce KCRM data with the recent run using the recent 1.1.0 update to the pipeline. I run into this issue I have encountered before when MakeMasterSky is called when the DRP reaches the standard star observation:

image

However, if I attempt the same reduction using a relatively recent commit of the kcrm_merge branch, MakeMasterSky completes and I am able to continue up to the flux calibration steps

image

MNBrod commented 11 months ago

Do you know which commit you are pulling from? Is it the latest from kcrm_merge, or a commit from earlier? There was a lot of merging that just happened, and it's possible that something got lost along the way.

rremigio commented 11 months ago

I think I am running on the 35fbcb9d72d6a66d747486848dee0268f62d3acc commit from October 6; I think the .py files in my installation are missing changes from Oct 13 onwards.

scizen9 commented 11 months ago

I am unable to reproduce this error with the 1.1.0 version I have on my machine. This could be due to three things:

  1. In order to get a good wavelength solution, I had to use -M 0.5 on the command line
  2. I used the internal continuum flat for the observation
  3. I only reduced kr231104_00047.fits and did not combine it with the other std. observations

I have seen this error in the past, but it was always due to some problem with the data, in this case, it may be a bad wavelength solution. If you can display the kr231104_00024_2d.fits file and see how wiggly it is, that will tell you if the solution was good or not. You should see the arc lines as straight, without wiggles.

Otherwise, let me know the full reduction sequence for that standard: what flat did you use? Did you combine the three observations? Did you tweak the wavelength parameters to get a good wavelength solution?

rremigio commented 11 months ago

Thank you, I ended up taking your advice and set MIDFRAC = 0.5 within the .cfg file. That more or less fixed the problem, and theicube_2d files look fine.