search

Keck-DataReductionPipelines / KPF-Pipeline

KPF-Pipeline
https://kpf-pipeline.readthedocs.io/en/latest/
Other
11 stars 2 forks source link

Properly using `rough_wls` to fix the offset between LFC and ThAr wls #715

Open aaronhouseholder opened 1 year ago

aaronhouseholder commented 1 year ago

image

image

Based on the plots above, we're not reading in rough_wls properly. This is almost certainly why there's an offset between LFC and ThAr. We default to the rough_wls in two cases 1) when we don't find enough peaks for a given order and 2) on the first 10 orders on the green chip.

I don't have a very good understanding for how rough_wls is read in (we just do rough_wls=rough_wls in alg.py/wavelength_cal.py). We need to make sure that 1) we're accessing rough_wls properly and 2) that rough_wls is based on the most recent ThAr solution. Tagging @awhoward who might be able to quickly fix this.

awhoward commented 1 year ago

Thanks for identifying this issue, Aaron. I'll take a look in the next few days.