search

Keck-DataReductionPipelines / KPF-Pipeline

KPF-Pipeline
https://kpf-pipeline.readthedocs.io/en/latest/
Other
11 stars 2 forks source link

Fixed dark current estimation in QLP #729

Closed awhoward closed 9 months ago

awhoward commented 9 months ago

I fixed the code to determine dark current and annotate plots of dark images in the QLP.

awhoward commented 9 months ago

The commits from the last day add functionality to write the dark current measurements to the 2D header, as explained in this Issue (https://github.com/Keck-DataReductionPipelines/KPF-Pipeline/issues/493).

Since I modified the main recipe, I suggest scrutinizing the changes. I tested the main recipe on a sample of files and it appeared to run without failing.

awhoward commented 9 months ago

Here's another related Issue: https://github.com/Keck-DataReductionPipelines/KPF-Pipeline/issues/494

awhoward commented 9 months ago

@bjfultn - I think this is ready to merge. And it would be good to do so before merging https://github.com/Keck-DataReductionPipelines/KPF-Pipeline/pull/734, which contains some reorganization of the "Analyze" files.