search

Keck-DataReductionPipelines / KPF-Pipeline

KPF-Pipeline
https://kpf-pipeline.readthedocs.io/en/latest/
Other
11 stars 2 forks source link

Solar spectra are not using correct mask #774

Closed howardisaacson closed 1 month ago

howardisaacson commented 9 months ago

I think this routine needs updated to have the specific "sun" mask. "/KPF-Pipeline/blob/develop/modules/radial_velocity/src/alg_rv_init.py"

I will try to make a patch.

awhoward commented 9 months ago

Tagging @rrubenza for awareness.

howardisaacson commented 9 months ago

Pull request fixing this is in, and going through continuous integration tests now.

Howard

On Wed, Jan 10, 2024 at 11:18 AM Andrew Howard @.***> wrote:

Tagging @rrubenza https://github.com/rrubenza for awareness.

— Reply to this email directly, view it on GitHub https://github.com/Keck-DataReductionPipelines/KPF-Pipeline/issues/774#issuecomment-1885532743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFHJZQ4FVZRFNWNFPWHFDYN3SQ3AVCNFSM6AAAAABBUGJY56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGUZTENZUGM . You are receiving this because you authored the thread.Message ID: @.*** com>

--

Howard Isaacson Research Scientist in Astronomy University of California, Berkeley

howardisaacson commented 8 months ago

I think this pull request is pulled to develop, but the SoCal RVs from today (https://jump.caltech.edu/observing-logs/kpf/KP.20240115.78026.03) Screenshot 2024-01-16 at 4 17 04 PM Suggests the fix did not work. I will check it out.

awhoward commented 8 months ago

@howardisaacson -- I think the pipeline is running on the master branch right now.

howardisaacson commented 1 month ago

This issue was fixed long ago.