Keck-DataReductionPipelines / KPF-Pipeline

KPF-Pipeline
https://kpf-pipeline.readthedocs.io/en/latest/
Other
10 stars 2 forks source link

Python Smooth Pattern #813

Closed bjfultn closed 4 months ago

bjfultn commented 5 months ago

@RussLaher I added a couple versions of the smooth lamp pattern code here:

In both cases I struggle to reproduce the results on disk. The _new version may tread pixels within a kernel's width of the edge differently but I don't have a good reason that the _mt version would produce different results. In both cases the differences are usually 0.01-0.1 counts so it may be close enough. I think this is about as close as I can get it without a more detailed understanding of the edge and outlier treatment. @RussLaher lets work on this together when you get back.

RussLaher commented 4 months ago

Please merge the smooth-pattern branch directly into the develop branch (the [feature/upgrade_20240220 branch will be abandoned).

RussLaher commented 4 months ago

I made changes so your multi-threaded codes give similar results to the original script (make_smooth_lamp_pattern.py).