search

Keck-DataReductionPipelines / KPF-Pipeline

KPF-Pipeline
https://kpf-pipeline.readthedocs.io/en/latest/
Other
11 stars 2 forks source link

new QC module for improper exposure termination, aka smeared readout #950

Closed howardisaacson closed 3 weeks ago

howardisaacson commented 1 month ago

Exposures that have the smeared readout contribute to noise in the LFC wavelength solution when they are improperly included in the masters stacks. This easy to identify visually on LFC and etalon frames but challenging on ThAr, and darks for example. This pull request adds a QC test that checks if the desired exposure time is near to the actual exposure time. These bad-readout frames all have an 'actual' exposure time of between 6 and 6.6 seconds.

howardisaacson commented 3 weeks ago

I added a QC definition. Let me know if you think I should extend it to all levels (L1/L2) or if the L0 qc test will propagate to the next levels.

awhoward commented 3 weeks ago

I think the L0 check is sufficient as QC keywords are inherited by downstream data products.

howardisaacson commented 3 weeks ago

QC definitions added on line 574. Please double check. A logic error and logic error was also fixed.