Closed lfuhrman closed 1 year ago
That is in case the logger object is not passed. It currently is configured to log to stdout, but there are several files that use db_conn. The log_msg is used to avoid the need to update a lot files right now in the released version.
Understood. In that case I will approve this pull request.
On giving this a good second look, I'm not sure that
log_msg
is necessary. If configured correctly, the logger should be formatted to output to sdout. Furthermore it introduces some potentially confusing log level codes. We can most likely accomplish what log_msg sets out to do by setting up the logger correctly e.g.Then just use the logger directly. No need for
log_msg