search

KeenS / www-authenticate

missing HTTP WWW-Authenticate header parser/printer for hyper 0.10.x
https://crates.io/crates/www-authenticate
MIT License
6 stars 6 forks source link

PR with lots of improvements #4

Open lattice0 opened 3 years ago

lattice0 commented 3 years ago

I made several improvements, including eliminating lots of unsafe calls. I also added support for the Authorization header, with serialization. I also made hyperx optional, which is good for eliminating dependencies.

Can I send a PR? Would you like me to enhance something?

Additionally, I made some add ons that I don't know if you have interest to keep in this library, but would be nice to integrate them here as optional features: https://github.com/lattice0/rust_rtsp_client/blob/ecd755476c48fd33774e01af7fc41a081e0e4f3f/src/www_authenticate_utils.rs

These are for generating the digest messages, with support for MD5, Sha1, Sha256, Sha512, all them with Sess versions too, and with RFC tests working.

PS: all this work is ongoing so I'll make it better and clean.

KeenS commented 3 years ago

Sorry for late reply. It was holiday season in Japan.

Can I send a PR?

Sure. I appreciate your contribution!

I made some add ons that I don't know if you have interest to keep in this library

Great. However as this library is not eagerly maintained I wouldn't like to add new features. One possible option is, if you will, that I add you as a maintainer of this repo and you maintain that feature. How do you feel about this option?

lattice0 commented 3 years ago

Ok let me see. I'm talking with another person that wants to include www authenticate features on his server. I made it work for my client. Let's see if he also wants to contribute, then we can maintain it.

Will answer soon.

Enviado via ProtonMail móvel

-------- Mensagem Original -------- Ativo 5 de mai. de 2021 14:52, κeen escreveu:

Sorry for late reply. It was holiday season in Japan.

Can I send a PR?

Sure. I appreciate your contribution!

I made some add ons that I don't know if you have interest to keep in this library

Great. However as this library is not eagerly maintained I wouldn't like to add new features. One possible option is, if you will, that I add you as a maintainer of this repo and you maintain that feature. How do you feel about this option?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bacongobbler commented 2 years ago

One possible option is, if you will, that I add you as a maintainer of this repo and you maintain that feature.

Hey @KeenS! We're using this crate over at https://github.com/krustlet/oci-distribution. We've updated it to hyperx 1.3 (which we upstreamed in #5), and we've made a number of refactoring improvements to the crate.

If the offer is still available, we'd be happy to continue maintaining this crate.

lattice0 commented 2 years ago

@bacongobbler it looks like there's still lots of unsafe calls. Check my PR, I cleaned all of the unsafe calls (if I remember correctly)

flavio commented 2 years ago

@bacongobbler: @KeenS has just accepted https://github.com/KeenS/www-authenticate/pull/6 which brings takes all the fixes we've done inside of the oci-distribution repo. Plus he just tagged and published a new version of the crate on crates.io :heart: