KeenSoftwareHouse / SpaceEngineers

2.94k stars 894 forks source link

SpaceEngineers.Game needs SteamSDK Reference #221

Open meson800 opened 9 years ago

meson800 commented 9 years ago

Using the latest commit, 0a54ff9af701b5ac70094424b27f7b71c1390e8b, build fails unless SteamSDK.dll is added as a reference to the SpaceEngineers.Game project.

jkells commented 9 years ago

+1 can't build anymore

wardmatt1 commented 9 years ago

+1

Sibz commented 9 years ago

@jkells @wardmatt1 Add SteamSDK.dll as a reference to the SpaceEngineers.Game project, just don't push the changes to the proj file.

thomas-frantz commented 9 years ago

I've added it to mine and I still can't build. Still messing with it though.

Sibz commented 9 years ago

@Coreinsanity The latest build has it now, if your not able to build its for another reason. Check here for common build issues.

Sibz commented 9 years ago

@meson800 Are you able to close this issue when you get a chance. Thank you!

thomas-frantz commented 9 years ago

@Sibz I'm not sure how it's a separate issue. I can't build because "SteamSDK could not be found", even though it's in the reference list.

Error   250 The type or namespace name 'SteamSDK' could not be found (are you missing a using directive or an assembly reference?) SpaceEngineers\Sources\SpaceEngineers.Game\Entities\Blocks\MyMedicalRoom.cs  20  7   SpaceEngineers.Game

Clean clone of the project, setup the content directory, etc. Building in release or debug, it still doesn't seem to like the SteamSDK in the project, or even in the steam version of the game. Yeah, it's there in the latest, but it doesn't seem to like it.

Edit: also that thread doesn't help me at all, this issue isn't even close to described in that thread.

Sibz commented 9 years ago

@Coreinsanity Sorry I thought it was resolved with the latest build. I did a clean clone of the project and it resolved it for me. Try Build -> Clean from the top menu. Then build the projects individually to see where it fails. Right Click Sandbox.Common, build, and repeat for Sandbox.Game, Sandbox.Graphics etc etc

meson800 commented 9 years ago

@Sibz @Coreinsanity I believe the problem is if our individual versions of Visual Studio handle reference paths case sensitive or not. (I'm using VS 2013 Pro). On the latest build/clean clone, I still get the error.

In the SpaceEngineers.Game project file, line 50, it refers to

<HintPath>..\..\3rd\SteamSDK\Debug\x64\SteamSDK.dll</HintPath>

whereas the actual paths use a lowercase debug and release.

This is confirmed by adding the reference again; I get the following git diff

-      <HintPath>..\..\3rd\SteamSDK\Debug\x64\SteamSDK.dll</HintPath>
+      <HintPath>..\..\3rd\SteamSDK\debug\x86\SteamSDK.dll</HintPath>

I'm submitting a pull request to fix, but I wonder if Keen's internal VCS actually has those paths in uppercase, and therefore the PR wouldn't be pulled.

meson800 commented 9 years ago

Actually, the issue is that it refers to the x64 DLL, which we don't have, instead of the case sensitive issue