KeenSoftwareHouse / SpaceEngineers

2.93k stars 896 forks source link

[Request] If a server returns its version as 00_000_000, join anyway. #558

Closed aaronfranke closed 5 years ago

aaronfranke commented 7 years ago

For some reason, sometimes the server's game version reports incorrectly as 00_000_000. I understand why this check exists, but if this version is returned, then obviously the check failed. Instead of being unable to join the game, it'd make more sense to just join anyway. The person joining probably knows that they're joining a compatible server, as usually it's a friend's server.

N3X15 commented 7 years ago

Wouldn't it be more productive to fix the issue where it returns 00_000_000?

aaronfranke commented 7 years ago

Probably, but seeing as how it hasn't been fixed for years, Keen must not be caring about that bug, or don't know how to fix it.

N3X15 commented 7 years ago

Are there reproduction steps for getting that version? I'd be happy to make a PR (although the version of SE in the repo is 22 days old now)

aaronfranke commented 7 years ago

I have no idea how to reproduce, it just seems to happen randomly.

mexmer commented 7 years ago

if server that is returning version 000_000_000 is using SESE, you might ask SESE authors instead, i don't believe there is issue with server itself. At least i never seen this issue, i'm running vanilla server since 1.070 or so.

N3X15 commented 7 years ago

SECE won't even list standard SE servers, and vice versa. That's by design.

aaronfranke commented 7 years ago

I'm not using SESE and I don't even know what that is.

aaronfranke commented 5 years ago

Closing since SE no longer uses GitHub.